-
Notifications
You must be signed in to change notification settings - Fork 14.9k
release/21.x: [libc++] Fix std::variant evaluating template arguments too eagerly (#151028) #153064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ldionne What do you think about merging this PR to the release branch? |
@llvm/pr-subscribers-libcxx Author: None (llvmbot) ChangesBackport f5f5824 Requested by: @ldionne Full diff: https://github.com/llvm/llvm-project/pull/153064.diff 2 Files Affected:
diff --git a/libcxx/include/__type_traits/invoke.h b/libcxx/include/__type_traits/invoke.h
index 5ff2efbe5faaf..3f5626c014432 100644
--- a/libcxx/include/__type_traits/invoke.h
+++ b/libcxx/include/__type_traits/invoke.h
@@ -67,20 +67,20 @@ _LIBCPP_BEGIN_NAMESPACE_STD
#if __has_builtin(__builtin_invoke)
-template <class... _Args>
-using __invoke_result_t _LIBCPP_NODEBUG = decltype(__builtin_invoke(std::declval<_Args>()...));
-
template <class, class... _Args>
struct __invoke_result_impl {};
template <class... _Args>
-struct __invoke_result_impl<__void_t<__invoke_result_t<_Args...> >, _Args...> {
- using type _LIBCPP_NODEBUG = __invoke_result_t<_Args...>;
+struct __invoke_result_impl<__void_t<decltype(__builtin_invoke(std::declval<_Args>()...))>, _Args...> {
+ using type _LIBCPP_NODEBUG = decltype(__builtin_invoke(std::declval<_Args>()...));
};
template <class... _Args>
using __invoke_result _LIBCPP_NODEBUG = __invoke_result_impl<void, _Args...>;
+template <class... _Args>
+using __invoke_result_t _LIBCPP_NODEBUG = typename __invoke_result<_Args...>::type;
+
template <class... _Args>
_LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR __invoke_result_t<_Args...> __invoke(_Args&&... __args)
_NOEXCEPT_(noexcept(__builtin_invoke(std::forward<_Args>(__args)...))) {
diff --git a/libcxx/test/std/utilities/variant/variant.variant/variant.ctor/T.pass.cpp b/libcxx/test/std/utilities/variant/variant.variant/variant.ctor/T.pass.cpp
index 142da1d820d9a..6111138726dbc 100644
--- a/libcxx/test/std/utilities/variant/variant.variant/variant.ctor/T.pass.cpp
+++ b/libcxx/test/std/utilities/variant/variant.variant/variant.ctor/T.pass.cpp
@@ -173,6 +173,11 @@ void test_vector_bool() {
assert(std::get<0>(v) == true);
}
+struct ConvertibleFromAny {
+ template <class V>
+ ConvertibleFromAny(V) {}
+};
+
int main(int, char**) {
test_T_ctor_basic();
test_T_ctor_noexcept();
@@ -180,5 +185,16 @@ int main(int, char**) {
test_no_narrowing_check_for_class_types();
test_construction_with_repeated_types();
test_vector_bool();
+
+ { // Check that the constraints are evaluated lazily (see https://github.com/llvm/llvm-project/issues/151328)
+ struct Matcher {
+ Matcher() {}
+ Matcher(std::variant<ConvertibleFromAny>) {}
+ };
+
+ Matcher vec;
+ [[maybe_unused]] Matcher m = std::move(vec);
+ }
+
return 0;
}
|
@ldionne (or anyone else). If you would like to add a note about this fix in the release notes (completely optional). Please reply to this comment with a one or two sentence description of the fix. When you are done, please add the release:note label to this PR. |
…lvm#151028) This has been reported in llvm#116709 (comment). Fixes llvm#151328 (cherry picked from commit f5f5824)
Backport f5f5824
Requested by: @ldionne